Brussels | ITP-2025-1 | Pinky Benitez | Week-2 | Form controls#30
Open
Pinx-pinx wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Open
Brussels | ITP-2025-1 | Pinky Benitez | Week-2 | Form controls#30Pinx-pinx wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Pinx-pinx wants to merge 6 commits intoHackYourFutureBelgium:mainfrom
Conversation
Member
|
Well done, @Pinx-pinx What You Did Well
What Needs Improvement
Example Correction<!-- Remove this extra fieldset closing tag -->
</fieldset> <!-- Delete this one -->
<!-- Add a submit button at the end of the form -->
<button type="submit">Submit</button> |
Collaborator
Author
|
Hello @talmurshidi I’ve made all the requested changes. Please review when you have time. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-My form is semantic html only.
-All inputs have associated labels.
-My Lighthouse Accessibility score is 100.
-I have defined a valid name
-I have required a valid email.
-I have required one colour from a defined set of 3 colours.
-I have required one size from a defined set of 6 sizes.
Questions
Ask any questions you have for your reviewer.